Firstly Im a noob to coding, clearly :D.
Ive followed a [decent runner tutorial][1] and then tried to make some changes to the movement on the x axis. The character currently moves using a character controller but does so smoothly while left or right is held down. I tried to change the script so that the character moves once to the left or right depending on the button pressed. Ive tried to make it so that the character is always locked to one of 5 positions on the x axis (-2, -1, 0, 1 & 2).
Ive tried many different tweaks to the code I have, but in the end I just ended up crashing the game with a do while loop. It is one of those things that seemed like it would be an easy change to make, but I ended up spending half of my day on it and now Im just too burnt out and frustrated to think clearly about this issue. Therefore I would really appreciate some advice from the geniuses on this site.
This is the script; it used to move left and right smoothly but not in increments when the x movement section used moveVector.x = -xSpeed; for left and the opposite for right, but ive made functions and added an if statement that checks the character's position - and I thought that would limit the game from crashing as that function would only be called once when the button is pressed (instead of on every update) but the game crashes so Im lost now (im not even sure if it is the function getting called every update or the do while loop never ending, but whether i move left or right the game crashes currently - probably the loop?).
using UnityEngine;
using System.Collections;
public class CharacterMotor : MonoBehaviour {
CharacterController controller;
Vector3 moveVector;
float verticalVelocity = 0.0f;
public float gravity = 12.0f;
private float animationDuration = 2.0f;
bool isDead = false;
float speed = 5.0f;
float xSpeed = 10.0f;
float startTime;
Vector3 position;
// Use this for initialization
void Start () {
controller = GetComponent();
startTime = Time.time;
}
// Update is called once per frame
void Update () {
if (isDead)
return;
if (Time.time - startTime < animationDuration)
{
controller.Move(Vector3.forward * speed * Time.deltaTime);
return;
}
moveVector = Vector3.zero;
if (controller.isGrounded)
{
verticalVelocity = -1f;
}
else
{
verticalVelocity -= gravity * Time.deltaTime;
}
//X - Left & Right
// old bit, before mobile build was this: moveVector.x = Input.GetAxisRaw("Horizontal") * xSpeed;
if(Input.GetMouseButton(0))
{
if (transform.position.x == 0.0f || transform.position.x == 1.0f || transform.position.x == 2.0f || transform.position.x == -1.0f || transform.position.x == -2.0f)
{
if (Input.mousePosition.x > (Screen.width / 2) && position.x < 2)
{
MoveRight();
}
else if (Input.mousePosition.x < (Screen.width / 2) && position.x > -2)
{
MoveLeft();
}
}
}
//Y - Up & Down
moveVector.y = verticalVelocity;
//Z - Forward & Back
moveVector.z = speed;
controller.Move(moveVector * Time.deltaTime);
}
public void SetSpeed (float modifier)
{
speed = 5.0f + modifier;
}
private void OnControllerColliderHit(ControllerColliderHit hit)
{
if (hit.gameObject.tag == "Enemy" && hit.point.z > transform.position.z + (controller.radius/2)) //&& hit.point.y > 0.1f)
Death();
}
private void Death()
{
isDead = true;
Debug.Log("Dead");
GetComponent().OnDeath();
}
void MoveRight()
{
position = transform.position;
do
{
moveVector.x = xSpeed;
} while (transform.position.x < position.x + 1.0f);
}
void MoveLeft()
{
position = transform.position;
do
{
moveVector.x = -xSpeed;
} while (transform.position.x > position.x - 1.0f);
}
}
Learning coding is fun, but somehow playmaker (state machine) logic seemed to make sense for my brain much quicker...
Thank you all for any help or advice you can offer.
[1]: https://www.youtube.com/watch?v=7jdL5538bEo&index=1&list=PLLH3mUGkfFCXps_IYvtPcE9vcvqmGMpRK
↧